Etuldan / MidiControl

MIDIControl is a standalone software (Windows Only), to remote control OBS, remote control your GoXLR, act as Soundboard, send message in Twitch Chat, and more..., with any MIDI controller like APC (from AKAI) or Launchpad (from Novation).
GNU General Public License v3.0
65 stars 11 forks source link

MIDIControl hangs for me as soon as it should connect to OBS #9

Closed Snickbrack closed 1 year ago

Snickbrack commented 2 years ago

I am doing following steps:

  1. Install MIDI
  2. Open OBS and change Websocket-Settings
  3. Open MIDI and put in all of the Websocket-Settings
  4. Plug-In MIDI Device
  5. Restart MIDI to let it do its thing
  6. OBS recognizes a connection for 0-1 seconds and then loses it
  7. MIDI hangs itself up immediately

What should I do now?

Snickbrack commented 2 years ago

I have cloned the code and I was able to track it down to:

OBSControl.cs Line: 116 obs.Connect("ws://" + options.options.Ip, options.options.Password);

This is the deadlock for me.

Snickbrack commented 2 years ago

I have also created custom firewall rules to allow all connections from the MidiControl-App. But no luck.

Etuldan commented 2 years ago

Which version of obs-websocket is installed on OBS ? v4.9.1 is the max supported at the moment for MIDIControl.

Snickbrack commented 2 years ago

Yes I saw this and had the version 5 installed earlier and switched back to v4.9.1 and this worked then.

But... I got an error then saying Input string was not in a correct format for line 122 in OBSControl.cs

I had to manually comment out the lines 122-126 to make it fully work.

But this was not that big deal.

Great tool btw :)

Etuldan commented 2 years ago

Did you entered the correct credentials that you registered on OBS-websocket ?

Snickbrack commented 2 years ago

Yes and the connection was possible and if I comment out these lines then I can use it as it is meant to be. Just these lines are "bad"

Etuldan commented 2 years ago

These "lines" are responsible for the connection to OBS, so removing them will maybe solve the hangup issue, but it would be then impossible to MIDIControl to connect to OBS. You may have 2 instances of MIDIControl opened, thus, the 2nd one hangup

Snickbrack commented 2 years ago

No, actually the Lines with the Version-Check are not necessary for me. And I would not understand it if they would be.

Why are you doing a Version-Check of OBS-Websocket? Just mention the version-to-use somewhere and done.

Etuldan commented 1 year ago

Could you retry with the latest version 2.0.0.1 ?