search

Etuldan / spaRSS

Based on Flym and Sparse RSS, this checks RSS/Atom news feeds, polling for updates from the device on a regular basis. Fetched items are available for offline reading.
Other
143 stars 31 forks source link

Navigation drawer (A.K.A. "left panel") does not adhere to Google Material Design Navigation Drawer Guidelines #93

Open wp9015362 opened 9 years ago

wp9015362 commented 9 years ago

@Etuldan :

The navigation drawer (A.K.A. "left panel") does not adhere to the Google Material Design Navigation Drawer Guidelines, see:

https://www.google.com/design/spec/patterns/navigation-drawer.html

Just one example:

The width of the navigation drawer in spaRSS is incorrect. According to the guidelines the width should be:

[...] Equal to the screen width minus the height of the action bar. In the example shown this is 56dp from the right edge of the screen. [...].

In spaRSS the navigation drawer is not wide enough.

Could you please fix that and all other things that should be done according to the Google Material Design Navigation Drawer Guidelines?

Regards

Etuldan commented 9 years ago

"Side nav width: Equal to the screen width minus the height of the action bar. In the example shown this is 56dp from the right edge of the screen. The maximum width of the nav drawer is five times the standard increment (56dp on mobile and 64dp on tablet)."

So the max width (on mobile) should be 5+56 = 280dp

wp9015362 commented 9 years ago

@Etuldan :

Did you post that just for the record?

Or because you are saying that spaRSS is already doing it correctly?

I had a look at the Google Play Store app, the Google Gmail app, the Google Calendar app, the Amaze File Manager app, the Telegram app and many more apps and in all of them the navigation drawer is wider than in spaRSS.

For comparison, here the screenshots from https://github.com/Etuldan/spaRSS/issues/71, the first screenshot is showing Amaze File Manager, the second one is showing spaRSS:

Image Image

As you can see, the navigation drawer is wider in Amaze File Manager.

All other apps that I know of have the same width as Amaze File Manager.

It's just spaRSS where it's different.

Regards

Etuldan commented 9 years ago

I don't know if spaRSS is doing correctly (and it seems not). But i was looking for the max width on tablet / portrait orientation, and I found this (on google material design guidelines) So, it's quite messy for me.