depends_on not respected

EugenMayer / docker-sync

Run your application at full speed while syncing your code for development, finally empowering you to utilize docker for development under OSX/Windows/*Linux

GNU General Public License v3.0

3.54k stars 290 forks source link

depends_on not respected #455

Closed ain closed 7 years ago

ain commented 7 years ago

Error/Feature Requestion/Docs

Whenever using docker-sync-stack start it behaves differently from docker-compose up -d in the way it treats the order to start up services.

Docker Driver

d4m

Sync strategy

native_osx

your docker-sync.yml

version: '2'
options:
  verbose: true
syncs:
  app-source:
    src: '.'
    #sync_strategy: 'unison'
    notify_terminal: true
    sync_excludes: ['log/', 'tmp/cache']
    sync_args:
      - "-prefer newer"
      - "-ignore='Path .git'"
      - "-ignore='BelowPath .git'"

OS

macOS

EugenMayer commented 7 years ago

Both commands run docker-compose,

stack start is the same as sync + manual docker compose start

EugenMayer commented 7 years ago

Please read what depends on does and what it does not offer and add health checks to really orchestrate service start orders

ain commented 7 years ago

I actually tried several times and was unable to reproduce the issue without docker-sync. Not sure if it could be a difference from v3 that brought a change in depends_on in general…

EugenMayer commented 7 years ago

you can ask here https://github.com/xeger/docker-compose since we use this as an abstraction layer for docker-compose - but AFAIR in the end, they actually do call the cli, so it should not matter, v3 or v2, depends on the dc version you have