Run your application at full speed while syncing your code for development, finally empowering you to utilize docker for development under OSX/Windows/*Linux
GNU General Public License v3.0
3.54k
stars
289
forks
source link
Fix docker-sync strategy detection on newer versions of docker on mac #836
I was having issues trying to rely on the default strategy, I was getting unison when the expected was native-osx as I was running on mac.
Here are some scenarios I tested:
When using the latest docker desktop (4.17.0), without Virtualization Framework activated, the default strategy fall back to unison
I tested the commands pgrep -q com.docker.hyperkit and pgrep -q com.docker.virtualization and both return exit 1
When enabling the Virtualization Frameware, the pgrep -q com.docker.virtualization command returns exit 0 and the default strategy was correct (native-osx)
I also tested on Docker Desktop 4.2 with the same results.
I figure that maybe we want to detect whether we are using Docker Desktop on a mac, and then fallback to detect the virtualization processes.
I was having issues trying to rely on the default strategy, I was getting
unisonwhen the expected wasnative-osxas I was running on mac.Here are some scenarios I tested:
When using the latest docker desktop (4.17.0), without Virtualization Framework activated, the default strategy fall back to
unisonI tested the commands
pgrep -q com.docker.hyperkitandpgrep -q com.docker.virtualizationand both returnexit 1When enabling the Virtualization Frameware, the
pgrep -q com.docker.virtualizationcommand returnsexit 0and the default strategy was correct (native-osx)I also tested on Docker Desktop 4.2 with the same results.
I figure that maybe we want to detect whether we are using Docker Desktop on a mac, and then fallback to detect the virtualization processes.
Any feedback is welcome on the changes proposed