EugenMayer / helm-charts

Helm charts for applications no official chart exists for
24 stars 18 forks source link

ingress error can't evaluate field Values in type interface #22

Closed christianhuth closed 2 years ago

christianhuth commented 2 years ago

When running current version (0.9.7) of Helm chart with the following test-values:

externUrl: test.local
ingress:
  enabled: true

Error: template: rundeck/templates/ingress.yaml:36:28: executing "rundeck/templates/ingress.yaml" at <.Values.nginx.enabled>: can't evaluate field Values in type interface {}

I think this happens because of iteratering over the ingressPaths-variable which changes scope and making the Values unavailable. But i'm not sure about this.

christianhuth commented 2 years ago

Seems to be the same issue as shown here: https://github.com/helm/helm/issues/1311#issuecomment-252669445

christianhuth commented 2 years ago

Can be solved by using $.Values.nginx.enabled instead of .Values.nginx.enabled.

EugenMayer commented 2 years ago

Thanks for the effort. Since it is all your finding, do you want to create a PR? You can also include the helpers you mentioned for a nicer format.

EugenMayer commented 2 years ago

In this PR we should also adjust values-test.yaml to include the ingress router so we test those properly.

I guess sooner than later i will use some github actions to smoke test the helm charts. But i kinda dodge this all the time since we usually use azure pipelines, i used Travis for all other projects and i guess i finally need to learn gh actions of the loss projects.

christianhuth commented 2 years ago

Thanks for the effort. Since it is all your finding, do you want to create a PR? You can also include the helpers you mentioned for a nicer format.

this will be fixed by my pending pr https://github.com/EugenMayer/helm-charts/pull/19

EugenMayer commented 2 years ago

If you strip down #19 and remove the < 1.19 compat, i'am with you. Otherwise i will patch this issue specifically

EugenMayer commented 2 years ago

has been fixed by #19 - thank you @christianknell for the contribution