search

Eugene-Mark / bigdata-file-viewer

A cross-platform (Windows, MAC, Linux) desktop application to view common bigdata binary format like Parquet, ORC, AVRO, etc. Support local file system, HDFS, AWS S3, Azure Blob Storage ,etc.
GNU General Public License v2.0
287 stars 54 forks source link

Instead hardcoded "\\" #14

Closed sedzisz closed 3 years ago

sedzisz commented 3 years ago

Please use "File.separator" it will work on all OS not only on Windwos

https://github.com/Eugene-Mark/bigdata-file-viewer/blob/85be0bca8950adaca16d6704f03f992a08750da9/src/main/java/org/eugene/persistent/SqlliteWrapper.java#L15

$ java -jar BigdataFileViewer-1.2-SNAPSHOT-jar-with-dependencies.jar 
java.sql.SQLException: opening db: '/home/<user>\bdf.db': Permission denied
Eugene-Mark commented 3 years ago

@sedzisz Thanks for this information. Would you like to submit a PR to fix the issue? If sure, I will assign it to you.

sedzisz commented 3 years ago

Sorry ofc :)