search

Eugene-Mark / bigdata-file-viewer

A cross-platform (Windows, MAC, Linux) desktop application to view common bigdata binary format like Parquet, ORC, AVRO, etc. Support local file system, HDFS, AWS S3, Azure Blob Storage ,etc.
GNU General Public License v2.0
287 stars 54 forks source link

Simplify build process #21

Closed barabulkit closed 3 years ago

barabulkit commented 3 years ago

Hello, i added a profile for java 11 users (it may be work with earlier versions, but not earlier than 1.8, i have not tested this yet) with this profile its easier to build project for newcomers, so that they don't need to add java fx manually, or install something with apt and so on. I tested this on windows 10 with java 13.0.2 on cent os 7 with java 11.0.11 with vendor Red Hat, Inc. (jdk from their repo) on mac os 10.13 high sierra 64 bit with java openjdk 15.0.2 (installed with maven after executing brew install maven) everything worked without adding or installing java fx manually to build this you need to specify profile: mvn -Pj11 package if you not specify the profile, everything will work as it worked before the changes, so i think this changes should break anything that is already exists and working. Feel free to leave comments if i should add something to this, or decline pull request if you think that this changes is redundant.

Eugene-Mark commented 3 years ago

@barabulkit Thanks for this modification. However, the openjfx is under the GPL with the class path exception. It doesn't comply with license of this project. So maybe the best choice is still to let the user install javafx themselves.