Open EugeneChanJiajun opened 4 months ago
We designed our add / change grade to work this way to improve the user experience, as it allows for more flexibility in using it without users receiving error codes when using such similar functions.
Team chose [response.Rejected
]
Reason for disagreement: If the point of the add/change grade function being the same to improve user experience, I do not see the need to have two different function names in the first place. The developers mentioned that this is to improve user experience but wouldn't having two different commands that perform the exact same functionality confuse users more? Hence, I believe that this bug should not be rejected and should minimally be response.outofscope so that the developers can improve upon the function in future iterations of the product.
Initially the grade for MA1511 is NULL, but I am able to change the grade to A+ and it registers in the list. Intuitively that should not happen as there is no grade yet. Also when I use the change grade function to change a grade from NULL to A+, I am able to change the grade from A+ to B+ using the add grade function.