EugeneChanJiajun / pe

0 stars 0 forks source link

No difference/ unexpected behaviour between the add grade and change grade functionality. #4

Open EugeneChanJiajun opened 4 months ago

EugeneChanJiajun commented 4 months ago

Initially the grade for MA1511 is NULL, but I am able to change the grade to A+ and it registers in the list. Intuitively that should not happen as there is no grade yet. Also when I use the change grade function to change a grade from NULL to A+, I am able to change the grade from A+ to B+ using the add grade function.

image.png

soc-se-bot commented 4 months ago

Team's Response

We designed our add / change grade to work this way to improve the user experience, as it allows for more flexibility in using it without users receiving error codes when using such similar functions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If the point of the add/change grade function being the same to improve user experience, I do not see the need to have two different function names in the first place. The developers mentioned that this is to improve user experience but wouldn't having two different commands that perform the exact same functionality confuse users more? Hence, I believe that this bug should not be rejected and should minimally be response.outofscope so that the developers can improve upon the function in future iterations of the product.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** As mentioned above on the consequences of having two functions do the same thing, the severity of this bug should at least be severity.low/medium as it gives users the impression that the product is not yet complete. Also, it makes it inconsistent with what was given in the UG as it is explained that the add command is only to "add" a grade and the change command is to "change" an existing grade but in the program both commands can do both operations.