EugeneManushkin / CtagsSourceNavigator

Reworked Ctags Source Navigator plugin based on source code v0.93 beta compatible with Far3
GNU General Public License v2.0
16 stars 0 forks source link

Preview tag by F4 does not work if tag is situated in edited file #92

Closed EugeneManushkin closed 2 years ago

EugeneManushkin commented 2 years ago

Reproduced on latest stable FarManager v5959

EugeneManushkin commented 2 years ago

I found breaking change in FarManager https://github.com/FarGroup/FarManager/commit/384e51ec4f6e8eaa038dc286fe7b388f398fee42:

intptr_t WINAPI apiEditor(const wchar_t* FileName, const wchar_t* Title, intptr_t X1, intptr_t Y1, intptr_t X2, intptr_t Y2, unsigned long long Flags, intptr_t StartLine, intptr_t StartChar, uintptr_t CodePage) noexcept
{
...
            switch (editorExitCode)
            {
                case XC_OPEN_ERROR:
                    return EEC_OPEN_ERROR;
                case XC_LOADING_INTERRUPTED:
                case XC_EXISTS:
                    return EEC_LOADING_INTERRUPTED;
                default:
                {
                    Editor->SetEnableF6((Flags & EF_ENABLE_F6) != 0);
                    Editor->SetPluginTitle(&strTitle);
                    /* $ 15.05.2002 SKV
                      Зафиксируем вход и выход в/из модального редактора.
                      */
                    Global->WindowManager->ExecuteModal(Editor);
                    if (-1 == editorExitCode) Global->WindowManager->ExecuteModal(Editor); //<<<<<<<<<<<<<

What if exit code does not mean initialization failure?

EugeneManushkin commented 2 years ago

Fixed in FarManager build 5981