search

Eugenetanwl3881 / pe

0 stars 0 forks source link

Email verification is too restrictive #4

Open Eugenetanwl3881 opened 1 year ago

Eugenetanwl3881 commented 1 year ago

This example I used is a valid email (host route used for uucp mailers). However, the special characters limit for the app disallows me from adding this email.

This may cause issues as it can cause difficulties to contact the customers.

image.png

nus-pe-bot commented 1 year ago

Team's Response

Dear Tester,

Thank you for pointing this issue out. We have overlooked this issue and will fix this in our future implementations. This is caused by a faulty regular expression that validates the email entered. Fixing the regex can solve two problems we have about this. That is also why we think these two issues are duplicate of each other.

We also think that this is a feature flaw instead of a functionality bug because the error message is intended as per the user guide. It is just the way we designed this feature is a little bit off.

Thank you!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid email address allowed

Steps to reproduce :

  1. add new buyer - add-b n/John Doe ph/98765432 e/johnd@ddd a/311, Clementi Ave 2, #02-25 l/USA

Expected: Throw error for invalid input for email address

Actual: Allows the invalid input

Screenshot 2022-11-11 at 5.01.42 PM.png

[original: nus-cs2103-AY2223S1/pe-interim#2571] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Dear Tester,

Thank you for pointing this issue out. We have overlooked this issue and will fix this in our future implementations. This is caused by a faulty regular expression that validates the email entered. Fixing the regex can solve two problems we have about this. That is also why we think these two issues are duplicate of each other.

We also think that this is a feature flaw instead of a functionality bug because the error message is intended as per the user guide. It is just the way we designed this feature is a little bit off.

Thank you!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is not a duplicate bug as my email address is valid but the email cannot be added. The bug the developer team marked as duplicate is that the email is invalid but they allowed it to be accepted.

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]