Eugenetanwl3881 / pe

0 stars 0 forks source link

Edit command allows us to edit with a duplicate with no warning/error #9

Open Eugenetanwl3881 opened 1 year ago

Eugenetanwl3881 commented 1 year ago

For example, I am allowed to edit the name Hongyi to Hongyi again. This is quite improbable in real life usage. No warnings was given when this happens.

A warning/error would be helpful to the user to let them know they are keying in a duplicate

image.png

image.png

nus-se-script commented 1 year ago

Team's Response

Dear Tester,

Thank you for your report. However, we don't quite understand the issue here. When a user edits their contact to have the exact same field input as before, there are no duplicate contacts created and the edited contact will remain the same as before. A contact will only be counted as a duplicate if their names, their emails, and their person category are the same. This is stated under the FAQ section in our user guide (please see the following screenshot below).

Screenshot 2022-11-14 at 2.03.37 PM.png

The following screenshot demonstrate that when the user is trying to edit a person's contact to have the same name and same email as someone else in the address book, there will be an error message thrown to show that this person already exists in the address book.

Screenshot 2022-11-14 at 2.02.55 PM.png

Thank you!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The name of the buyer is allowed to be edited to the same name as before as described. We should give a warning/prevent that as much as possible. Although no new duplicate contact is created, the fact that I can edit a contact to exactly the same field value as it was initially was should be disallowed/warned (because the user should not be doing this in real-life usage if he/she is using the edit command)

Here is a clearer description of my issue: Suppose I have Hongyi as a name in index 2, I can edit index 2 and rename it to Hongyi again. A warning should be given or this should not be allowed at all. image.png

After running the command, it is a success with no warnings etc. image.png