search

Eugeny / ajenti-v

Virtual Hosting addon for Ajenti
ajenti.org/#product-ajenti-v
MIT License
225 stars 80 forks source link

Fix #178 #185

Closed Xefir closed 4 years ago

Xefir commented 9 years ago

Fix proposed by @karbowiak, tested and worked for me.

Please see the related issue : https://github.com/ajenti/ajenti/issues/764

Eugeny commented 9 years ago

This is totally not a good idea because it doesn't take in account the webapp code that might have changed. ajenti-ipc v apply is typically called from CI/deployment scripts and a restart of all related processes is required to make sure that newest app version is now running.

karbowiak commented 9 years ago

If a config script for supervisor is changed, update will know it, and restart it. It won't restart the already running processes that havn't changed.

Restart will restart everything, regardless of it it has changed or not. :)

Eugeny commented 9 years ago

Supervisor has no way of knowing if app code itself has been changed. And I don't mean PHP-FPM here. Think about app-server based deployments: gunicorn, puma, nodejs.

karbowiak commented 9 years ago

Ah yes, you're right.

Why not tie the supervisor services to the website then, and only restart those tied to it, and not every process running? :)