search

Eugeny / russh

Rust SSH client & server library
https://docs.rs/russh
964 stars 112 forks source link

Derive Debug where possible #374

Closed qsantos closed 5 days ago

qsantos commented 1 week ago

I mostly wanted to dbg! the server's Session, but I took the opportunity to add #[derive(Debug)] wherever I could.

Eugeny commented 1 week ago

A lot of these are empty structs and structs with security relevant fields that should not end up in some forgotten dbg! output. I could merge a handmade Debug impl with just the relevant fields for Session but not this.

qsantos commented 1 week ago

I have excluded the private keys from the Debug implementation of the server Session, but I probably missed some other secrets.

Eugeny commented 5 days ago

LGTM! @all-contributors add @qsantos for code

allcontributors[bot] commented 5 days ago

@Eugeny

I've put up a pull request to add @qsantos! :tada: