search

Eugeny / tabby

A terminal for a more modern age
https://tabby.sh
MIT License
58.93k stars 3.38k forks source link

Profile loss / config corruption #5355

Open tonycody opened 2 years ago

tonycody commented 2 years ago

Oh my God, after I updated to Alpha 169, all the previous SSH connection information was lost. None of them are synchronized. image connections is empty.

astromasoud commented 2 years ago

I also lost all my saved profiles last night after entering the master password wrong for one time. The sessions in recents were there but the profiles were all removed. I've tried to recreate the issue but hasn't happened again, so probably some random bug. I think the profile management should become more reliable to prevent such data losses. I had to re-add 20 hosts...

jaques-sam commented 2 years ago

Same for me, all my profiles were gone.

Eugeny commented 2 years ago

Immediately after a config is saved, there should be a config.yaml.backup in the same folder with the previous contents (this only works if you notice the config is gone immediately though) :(

Have you noticed any specific pattern that leads to data being lost? Like using multiple windows, etc.

astromasoud commented 2 years ago

Have you noticed any specific pattern that leads to data being lost? Like using multiple windows, etc.

That was actually my first time creating saved profiles, I closed the program soon after adding profiles and opened it again in less than a few minutes, entered the master-password wrong once, and after entering the program, the profiles were missing, but not the recent connections and other configs like the themes and colors, passwords, keys, etc, they were all still there.

I re-added my profiles and haven't had any issues since, no data loss so far. I tried to make it happen again but it didn't break!

jaques-sam commented 2 years ago

I know I disabled the CTRL+SPACE shortcut, the shortcut was enabled again after using the alpha 169 version.

astromasoud commented 2 years ago

I wanted to report an issue on the "Verify host keys" not remembering the "Accept and remember" after program restart, wanted to document the reproducing part, did a fast multiple on/off of the "Verify host keys" option under the SSH settings, and then immediately all my tens of saved profiles got deleted and lost! 🥲

image

image

Again the recent sessions are still in the list and the keys/passwords are there in the Vault. I also have the Master Passphrase option enabled. Other options are default.

version 1.0.172

astromasoud commented 2 years ago

I removed the program and all its files from the user data directories, did a fresh install and created all the profiles again. Everything was fine until I decided to increase the font size of the terminal from Settings > Appearance, upon clicking on the Up button to increase the size from 16 to 17, first it went to 14, then I clicked it 3 times to increase to 17. During one of these actions all the profiles were lost again! This time I had the online sync option enabled to maybe have a backup, but that was immediately synced with the deletion of all profiles, so it was lost, too. This time I'm going to disable the Master Passphrase, maybe that's the issue; I'm also disabling the automatic sync of the settings to prevent losing the online backup, too...

Please find a solution for this issue.

lolomin commented 2 years ago

Hi, got the same exact thing with tabby v1.0.173 and my own hosted tabby-web and gw ... lost all profiles/connexions suddenly :( don't even known how to reproduce

Karan1458 commented 2 years ago

Came around this bug today. Missed all profiles. I don't want any settings. Just give me one file point to manage all my connections profiles and custom location settings to pickup the file on each opening. I can sync it with cloud and manage it all over the pc easily. Prevent such data loss. We can encrypt that file too.

Details: Version: 1.0.164 Platform: Windows x64 10.0.22000 Plugins: none Frontend: xterm

zhjdotxmsme commented 2 years ago

same to me

I also lost all my saved profiles last night after entering the master password wrong for one time. The sessions in recents were there but the profiles were all removed. I've tried to recreate the issue but hasn't happened again, so probably some random bug. I think the profile management should become more reliable to prevent such data losses. I had to re-add 20 hosts...

same to me , I loss all my ssh connection information after entering wrong master password.

taythebot commented 2 years ago

I just enabled sync and restarted the app. It asked me for my master password and then says it can't decrypt "TypeError: Cannot read properties of undefined (reading 'version')". I tried erasing the config and restoring it from the sync, but same error.

I can see the recent connections, but no profile and vault....

Naolador commented 2 years ago

I'm experiencing the same issue. After an upgrade, everything is gone. My settings, profiles, plugins, all gone. Now I created a folder called "data" alone with the Tabby.exe and redo all the configures. Then I backed up that folder to another location. I think that would be a temporary workaround.

georgiosd commented 2 years ago

I'm not sure if it's for the same reason, but I don't seem able to sync my connections to the app.tabby.sh app. It only syncs the other settings or something?

Eugeny commented 2 years ago

Unfortunately I'm still unable to reproduce this reliably. In v183, there's a change to prevent further race conditions when saving config - https://github.com/Eugeny/tabby/pull/6885 - are you still experiencing config loss in 1.0.183?

raffymartin commented 1 year ago

Hello guys,

I can confirm this happened to me with the latest update 1.0.188 from January 04, 2023. I lost all my profiles, and they were around 30 profiles. I do image backups, and I'm trying to restore it to a new drive to see if I can see the config.yaml file back as the backup and the current one is basically the same file.

I guess I would need to stark backing up the whole AppData folder at the file level instead to easily recover it, if indeed that's all that needs to be done to recover the connections back.

Eugeny commented 1 year ago

There's now a potential fix for this in the nightly: https://github.com/Eugeny/tabby/actions/runs/4090823677

GitHub
potentially fix config corruption - #5355, #7874 · Eugeny/tabby@85bb7a2
A terminal for a more modern age. Contribute to Eugeny/tabby development by creating an account on GitHub.
yueyejinghun commented 1 year ago

I can also confirm this happened to me in version 1.0.188 on Windows after I changed 'Show recent profiles in selector' to 10. All profiles were gone and config.yaml reverted back to 4kb.

I had the entire %AppData%\tabby folder backed up so I could have my settings back. Unfortunately I also enabled automatic background settings sync in the backup, so every time I opened tabby, the settings were automatically synced to the 4kb version, ultimately I disconnected from the internet and restored my backup.

So here's some advice, do not enable 'Sync automatically' in 'Cloud sync', keep multiple backups and sync manually to the cloud

Edit: Changing the said value to 10 is not necessary, simply messing with that value from 1-10 is able to reproduce