Eugeny / tabby

A terminal for a more modern age
https://tabby.sh
MIT License
58.21k stars 3.35k forks source link

Hotkeys tab not working correctly #8756

Open CaptainFallaway opened 1 year ago

CaptainFallaway commented 1 year ago

Version: 1.0.197 Platform: Windows x64 10.0.19045 Plugins: none Frontend: xterm-webgl

I have encountered a problem where when I press on hotkeys in the settings it just won't budge or do anything when I press on another one of the settings tabs (see first image). Not only that but when I want to change a keybind, it seems like the popup that comes up doesn't register my keybinds nor look completely right, (see second images).

I just encountered these problems today and it has never been like this before, I've restarted the program to see if that would fix anything but to no difference. I do not know what I going on or if it can be simulated or not.

Hotkeys tab not working correctly: image

Trying to bind a new keybind: image

Edit:

When I'm inside the hotkeys section I not only can't change settings section but when I try to for example show the profile selector it just shows a blank input box.

image

And not only that when I try to set a new keybind and it doesn't work and press cancel, then no keybind then works at all, nothing happens when I try for example show the profile selector again. But then when I restart the program the hotkeys do work again, but when I repeat the steps of trying to set a new keybind the same thing happens.

Eugeny commented 1 year ago

Please capture DevTools console logs at the time of the issue: https://github.com/Eugeny/terminus/wiki/Debug-logs

GitHub
Debug logs
A terminal for a more modern age. Contribute to Eugeny/tabby development by creating an account on GitHub.
CaptainFallaway commented 1 year ago

(remade the message)

When I press a hotkey in the state where I've just opened the application then this appears:

image

And then when I press on the hotkeys section in settings this error doesn't stop appearing. The erros is spamming in the console at every event the application is capturing. And this error keeps popping up and doesn't stop at all till I restart the application:

image

image

From what I can see from one of the errors is that it tries reading properties from one of my already opened tabs, in this case, it was Cmder. And since it keeps appearing when the application is capturing my inputs I'm guessing that the error is blocking the main loop which leads to other functionality to stop working for example when I try to press a hotkey or try to enter the master password when connection to a ssh session it just doesn't work.

z-impi commented 1 month ago

I think i have the same issue. My custom shortcuts are not working. only the default ones. I switched toggle tabby window from strg+space to F12 and its not working. Other combinations also don't work. Posted this because i think its related. As stated the defaults are working.

CaptainFallaway commented 1 month ago

I have not really cared about this issue for a while, I might start digging again. It's just that It felt like a lone issue for a while.