Eugeny / tabby

A terminal for a more modern age
https://tabby.sh
MIT License
59.41k stars 3.39k forks source link

Passwords not being remembered #8928

Open b0bh00d opened 1 year ago

b0bh00d commented 1 year ago

Describe the problem: Tabby is not remembering SSH passwords, even though I have told it to by enabling the "Remember" checkbox. I am on Ubuntu 22.04 LTS, and I'm using Tabby v1.0.200.

To Reproduce: I installed Tabby directly from the github project, and it imported "known" connections from the .ssh/ folder when I started it. I opened the first, and it prompted me to enter the password. I entered it, and checked the "Remember" checkbox. I then told it to accept the fingerprint for the host, and it it connected. When I connect to this same host using Tabby again, it still prompts me for a password.

I looked at the system keychain ("Passwords & Keys"), and I see no new entries.

Eugeny commented 1 year ago

Which DE are you using? Tabby uses libsecret to interface with secret managers, maybe yours doesn't support it or requires an adapter

b0bh00d commented 1 year ago

This is what I'm seeing from apt list --installed | grep libsecret:

libsecret-1-0/jammy,now 0.20.5-2 amd64 [installed] libsecret-common/jammy,jammy,now 0.20.5-2 all [installed,automatic]

So, why isn't Tabby using it?

Which DE are you using?

I'm using the default DE that installs with Ubuntu 22.04 LTS (gnome?).

b0bh00d commented 1 year ago

I decided to take another run at this. Installing Tabby on a clean Ubuntu 22.04 LTS (in a VM) works as expected. It saves the password. On my "live" Ubuntu 22.04 LTS system, with lots of other software already installed, it still fails to remember the passwords using the same steps.

I don't know if this is relevant to my issue, but I ran Tabby from the command line, and immediately got this message:

Error: Bad atom
    at ReadFixedRequest.callback (/opt/Tabby/resources/app.asar/node_modules/x11/lib/xcore.js:465:29)
    at ReadFixedRequest.execute (/opt/Tabby/resources/app.asar/node_modules/x11/lib/unpackstream.js:41:10)
    at UnpackStream.resume (/opt/Tabby/resources/app.asar/node_modules/x11/lib/unpackstream.js:165:30)
    at UnpackStream.write (/opt/Tabby/resources/app.asar/node_modules/x11/lib/unpackstream.js:102:10)
    at Socket.<anonymous> (/opt/Tabby/resources/app.asar/node_modules/x11/lib/xcore.js:88:21)
    at Socket.emit (node:events:513:28)
    at Socket.emit (node:domain:489:12)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
    at Socket.Readable.push (node:internal/streams/readable:234:10) {
  error: 5,
  seq: 10,
  badParam: 0,
  minorOpcode: 0,
  majorOpcode: 17
}

I checked .config/tabby/log.txt, and this message does not appear in there. I checked /var/log/syslog, and the above error does appear in there.

I'm finding nothing about errors accessing the key ring.

sim4dim commented 1 year ago

I am seeing the same behavior (not saving ssh password) on MacOS 13.5.2 running Tabby 1.0.2