Alpha 205 might have broken "vibrancy" -- It's no longer translucent

Eugeny / tabby

A terminal for a more modern age

https://tabby.sh

MIT License

59.75k stars 3.4k forks source link

Alpha 205 might have broken "vibrancy" -- It's no longer translucent #9389

Open LBYPatrick opened 10 months ago

LBYPatrick commented 10 months ago

Describe the problem: That in 204, the gaussian blur glass texture for the window under macOS works if I turn on "vibrancy". But in 205, this feature has no effect. Is there a breaking change with the introduction of the background plugin?

To Reproduce: Simply upgrade to 205.

My machine specs:

Per neotech:


OS: macOS 14.2.1 23C71 arm64 
Host: MacBookPro18,3 
Kernel: 23.2.0 
Uptime: 3 days, 19 hours, 8 mins 
Shell: zsh 5.9 
Resolution: 1512x982 
Terminal: Tabby 
GPU: Apple M1 Pro 
Memory: 2815MiB / 16384MiB

And of course:

jukfiuune commented 7 months ago

Same issue on 207, for some reason while turning the feature off the blur appears for a few seconds. Also i tested on Linux, and can say that this is a macOS issue specifically! (AMD64 btw, not arm)

Neofetch: OS: macOS 13.6.1 22G313 x86_64 Host: Hackintosh (SMBIOS: iMac18,1) Kernel: 22.6.0 Uptime: 1 day, 9 hours, 3 mins Packages: 173 (brew) Shell: zsh 5.9 Resolution: 1920x1080 DE: Aqua WM: Quartz Compositor WM Theme: Blue (Dark) Terminal: Tabby CPU: Intel i3-7100 (4) @ 3.90GHz GPU: Intel HD Graphics 630 Memory: 5851MiB / 8192MiB

jukfiuune commented 7 months ago

So what's going on, is this going to be fixed?

fireblue commented 3 months ago

Hi, I had the same problem, googled and came across your issue.

Seems like upgrading to macOS 14 causes the problem.

I've made a fix in #9896

LBYPatrick commented 3 months ago

tysm! ~~I will try to make a build on my machine based on your PR and will keep you posted on the results!~~ I will try out your code with the new version!

Eugeny commented 3 months ago

@LBYPatrick you can grab the latest nightly build here, the fix should already be in it :) https://nightly.link/Eugeny/tabby/workflows/build/master

nightly.link | Repository Eugeny/tabby | Workflow build.yml | Branch master