Eugeny / tabby

A terminal for a more modern age
https://tabby.sh
MIT License
59.67k stars 3.4k forks source link

sudo not working on Linux #960

Open marcinbojko opened 5 years ago

marcinbojko commented 5 years ago

Version: 1.0.78 Platform: linux 4.18.0-13-generic Plugins: altair, clickable-links, quick-cmds, save-output, scrollbar, shell-selector, theme-gruvbox, title-control

Possible regression with sudo:

sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?

Funding this issue

Fund with Polar

elielam commented 5 years ago

Same here !

Ubuntu 18.04 Terminus 1.0.78

raphaelriehl commented 5 years ago

Same issue and same config as @elielam.

xingchenyefeng commented 5 years ago

Same here !

Ubuntu 18.04 Terminus 1.0.78

mrpatg commented 5 years ago

Same issue

Ubuntu 19.04 Terminus 1.0.78

ozlevka-work commented 5 years ago

Have the same Ubuntu 19.04 Terminus 1.0.78

lwyj123 commented 5 years ago

Same here !

Ubuntu 18.04 Terminus 1.0.78

ghost commented 5 years ago

Same issue here

ArchLinux 5.1.5-arch1-2-ARCH Terminus 1.0.78

NonStatic2014 commented 5 years ago

Same here. Any workaround?

Ubuntu 16.04 Terminus 1.0.78

mrpatg commented 5 years ago

I went with the previous release and didn't have the same issue there.

On Mon, Jun 3, 2019, 2:26 PM Klein Hu notifications@github.com wrote:

Same here. Any workaround?

Ubuntu 16.04 Terminus 1.0.78

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Eugeny/terminus/issues/960?email_source=notifications&email_token=AAFXNAPJ6BJAOZXNUA4E26DPYVO6XA5CNFSM4HPZAMLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2IZSI#issuecomment-498371785, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFXNAOQXABHY2IYYPCAMWDPYVO6XANCNFSM4HPZAMLA .

NonStatic2014 commented 5 years ago

Thank you to @mrpatg

The current workaround would be rolling back to 1.0.77. In the meanwhile, 1.0.79 still has this issue.

melonwool commented 5 years ago

Same issue here

Deepin GNU/Linux 15.10.1 Terminus 1.0.79

MaXZon3 commented 5 years ago

Same here.

Linux Mint 19.1

ghost commented 5 years ago

The problem seem to be electron v5. https://github.com/electron/electron/issues/18521

RafaelGondi commented 5 years ago

Same issue here.

Version: 1.0.80 Platform: linux 4.18.0-21-generic

rfuy commented 5 years ago

Same issue here.

Version: 1.0.80 Platform: gentoo x86_64 Linux 5.1.7

KubrikDevelopmentStudio commented 5 years ago

Same issue here.

Version: 1.0.81 Platform: linux 4.19.10-041910-generic

Paulpatou commented 5 years ago

Same issue here.

Version: 1.0.81 Platform: Linux 4.15.0-51-generic / Ubuntu 16.04

ilkerhalil commented 5 years ago

Same here ! Ubuntu 18.04 Terminus 1.0.78

Undomyr commented 5 years ago

Same issue.

Version: 1.0.82 Platform: Linux 5.1.8-1-Manjaro

kankaristo commented 5 years ago

If you're using tmux (screen may also work?), here's another workaround:

  1. Launch a new tmux session in some other terminal program (e.g. gnome-terminal)
  2. Detach from the session
  3. Attach to the session in Terminus

...and sudo works (probably because sudo is not a child process of Terminus/Electron, but of the tmux server).

Any new tmux window or session (started from within this session) will also have working sudo.

an333 commented 5 years ago

Same issue here.

Version: 1.0.87 Platform: Linux Mint 19.1 & KDE neon 15.6

juanmaioli commented 5 years ago

Same issue here

Deepin GNU/Linux 15.11 Terminus 1.0.87

mattisdada commented 5 years ago

I am also experiencing this for the last few releases Terminus 1.0.87 Fedora Workstation 30

jamezpolley commented 5 years ago

If you're using tmux (screen may also work?), here's another workaround:

As another alternative, you can ssh localhost. That spawns a new shell that's not a child of Terminus/Electron, so you can sudo from there.

ElDarco commented 5 years ago

Same issue here.

Version: 1.0.87 Platform: Linux Mint 19.1

reecebenson commented 5 years ago

Same issue here.

Version: 1.0.87 Platform: Ubuntu 18.04.1 LTS

armorsuitable commented 5 years ago

Ubuntu Meta 18.04

sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?
ghost commented 5 years ago

Same issue and output as @AngFl Version: 1.0.87 Platform: Pop!_OS 18.04

NuSkooler commented 5 years ago

The "+1"'s are piling up, I think they get it guys :)

Question for maintainers: What's the status on this? I think not being able to perform sudo-ish commands in Linux generally makes the terminal useless there :(

Eugeny commented 5 years ago

@nuskooler it's currently blocked by https://github.com/electron/electron/issues/18521 , so I'm waiting for the Electron to react. Unfortunately it doesn't seem that there is a workaround without them actually fixing this.

shanoaice commented 5 years ago

So is there any way to do sudo inside terminus? I'm experiencing the same issue.

Version:1.0.88 OS: deepin 15.11

shanoaice commented 5 years ago

I am not sure if you use a pty like node-pty instead of the built in child_process would work.

an333 commented 5 years ago

Sorry for my English. The latest working version for Linux was 1.0.77, all subsequent ones, including 1.0.88, do not work correctly with SUDO. What is the point of releasing versions for Linux if the main function does not work in them?

shanoaice commented 5 years ago

Sorry for my English. The latest working version for Linux was 1.0.77, all subsequent ones, including 1.0.88, do not work correctly with SUDO. What is the point of releasing versions for Linux if the main function does not work in them?

I thought the releasing progress may be automated, the author may not want to ruin the automation so he kept the default releasing.

shanoaice commented 5 years ago

@Eugeny Could you try to use something like node-pty in Terminus? This library may help.

Eugeny commented 5 years ago

@ksryy Terminus is using node-pty. Please see my previous reply regarding the upstream bug in Electron

NuSkooler commented 5 years ago

Looks like a fix may have landed in https://github.com/electron/electron/issues/18521

desenvolvedorfmais commented 5 years ago

Mint 19.1 ~ 19.2 Versão: 1.0.75 sudo with Terminus running sudo only on version 1.0.75 or lower. Versions 1.0.76 or higher not working sudo

PT BR

sudo com o Terminus funcionando o sudo somente na versão 1.0.75 ou inferior. Versões 1.0.76 ou superior não funcionando o sudo

Eugeny commented 5 years ago

I'm pleased to announce that sudo and other setuid commands now work in Alpha 91

elijah-rou commented 5 years ago

Hi @Eugeny ! I'm still getting this issue in the latest release (92).

Pop_OS! 19.10 Terminus 1.0.92

sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?

Paulpatou commented 4 years ago

@Eugeny , Same issue with Terminus 1.0.97 sudo: le uid effectif n'est pas 0. Est-ce que /usr/bin/sudo est sur un système de fichiers avec l'option « nosuid » ou un système de fichiers NFS sans privilèges root ?

iggz commented 4 years ago

Just install ubuntu 18.04.3 LTS this morning and killed all morning on this issue. Cant find a solution anywhere.

iggz@iggz-ub:~$ su - Password: su: Authentication failure iggz@iggz-ub:~$ sudo -i sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?

patjgardner commented 4 years ago

Same problem with Fedora 31. Looking into the problem I read this https://github.com/electron/electron/pull/19953 which mentions that the electron fix only applies to unsandboxed. So running 'terminus --no-sandbox' allows me to successfully run sudo in the shell without the error.

archit120 commented 4 years ago

This doesn't seem to be working for me. I'm on 1.0.98, Ubuntu 18.04

I'm using the bash terminal which might be the cause.

mattisdada commented 4 years ago

This issue was resolved for me for a while, but just updated (alpha 103) and it has reappeared once more :(

Running Fedora 31, zsh 5.7.1 (x86_64-redhat-linux-gnu)

patjgardner commented 4 years ago

I've updated to 1.0.103 (also on Fedora 31) using the Linux RPM and don't have the issue @mattisdada is reporting. I've tried sudo in both bash and zsh and it still works as expected for me.

mattisdada commented 4 years ago

@patjgardner Thanks for trying to replicate :)

I rebooted my machine after hearing you weren't having any issues, and the problem resolved itself. There must have been an issue during the upgrade because I still had the older Terminus running (101 maybe?) and maybe it didn't properly shutdown

You can probably close this again @Eugeny, sorry for raising a false alarm! I should've rebooted before reporting

jorepstein commented 4 years ago

I was experiencing this issue again on Ubuntu 18.04.4. Then I realized I had the alpha (105) installed so I installed 104 instead, and the problem seems to have been fixed.

guschinaglia commented 4 years ago

Same in OpenSUSE

rahacker2006 commented 4 years ago

Same in Ubuntu 20.04