Eugeny / tabby

A terminal for a more modern age
https://tabby.sh
MIT License
59.41k stars 3.39k forks source link

Using nano with specific text file over ssh hangs Tabby #9747

Open fcharron opened 4 months ago

fcharron commented 4 months ago

Version: 1.0.207 Platform: Windows x64 10.0.19045 Plugins: save-output Frontend: xterm

Tried multiple times to paste the contents of the following file: https://raw.githubusercontent.com/Requarks/wiki/main/config.sample.yml in nano over an ssh session (WSL2 running Ubuntu 20.04, connecting to another Ubuntu server) and it made Tabby hang. I tried the exact same procedure in Windows Terminal and it works just fine, so it shouldn't be my configuration or some network issue.

fcharron commented 4 months ago

Actually, even after editing the file in Windows Terminal, I can't even open nano and show the contents of the mentioned file in Tabby. Maybe there's some pattern in the file it doesn't like?

fcharron commented 4 months ago

To be clear, the entire Tabby app just fully hangs, the UI is completely unresponsive, and I can only kill it through the task manager.

claitz commented 4 months ago

This is a bug with nano, see https://github.com/microsoft/vscode/issues/180257 and the issue on nano's bug tracker here

As per this comment, this has been fixed with nano 8.0 and I can confirm it's no longer an issue for me!

fcharron commented 4 months ago

This is a bug with nano, see microsoft/vscode#180257 and the issue on nano's bug tracker here

As per this comment, this has been fixed with nano 8.0 and I can confirm it's no longer an issue for me!

While I agree it looks like this originates from this but in nano (good find btw 👍), I still don't think the entire UI, all other tabs/sessions should hang when this problem happens.