search

Eugleo / magic-racket

The best coding experience for Racket in VS Code
https://marketplace.visualstudio.com/items?itemName=evzen-wybitul.magic-racket
GNU General Public License v3.0
204 stars 28 forks source link

integrate with racket-langserver #10

Closed JJPro closed 4 years ago

JJPro commented 4 years ago

Resolves #7 Add Racket Language Client support.

Integrates with racket-langserver, which is required to be installed via: 

raco pkg install racket-langserver

This requires this PR to work perfectly. Until that PR got merged, we could have my local modified copy included in our project like now. 🎉🎉🎉

One place could be improved:

auto check and install racket-langserver if not installed. Maybe you can help with this.

output3

Eugleo commented 4 years ago

Thanks for the PR! I'll review it (hopefully) till the end of the week and let you know if I have any questions.

Eugleo commented 4 years ago

@JJPro I'm having problems with launching the extension. I think it's due to me not being able to download the submodules, as you didn't provide the .gitmodules file. Could you please paste its contents here?

Eugleo commented 4 years ago

@JJPro I pushed some commits, mostly fixing other issues, could you please merge them into your PR? I also added some simple CI to save me some headaches with formatting and code style.

Be sure to also read my previous comment about the submodules — you should probably commit the .gitmodules file when you're at it. Thanks!

JJPro commented 4 years ago

@Eugleo Yep, a rebase was done and racket-langserver was added as a submodule. A problem I discovered is that the fans could go crazy sometimes with the language server integrated. I'm not sure if that's due to implementation of racket-langserver or my code piece.

Please review. Thank you!

Eugleo commented 4 years ago

Seems to be working all right, thank you for the contribution!

There's one last problem that I didn't spot before: I fear the submodules won't work for users downloading the extension from the marketplace. I'll test it out and if it indeed doesn't work, I'll ditch the submodules and leave installing the langserver on the user.

We could then maybe join forces with @jeapostrophe and help him with the langserver itself, properly implementing the outline feature and whatnot. What do you say?

aymanosman commented 4 years ago

When do you plan on publishing this change? Looks very interesting.

Eugleo commented 4 years ago

Just making finishing touches, should be up on the marketplace later today.

    1. 2020 v 0:14, aymanosman notifications@github.com:

When do you plan on publishing this change? Looks very interesting.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Eugleo/magic-racket/pull/10#issuecomment-621493518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCF3IHGMXINOR77BN7DHH3RPCREDANCNFSM4MC4HXEA.