search

Eugleo / magic-racket

The best coding experience for Racket in VS Code
https://marketplace.visualstudio.com/items?itemName=evzen-wybitul.magic-racket
GNU General Public License v3.0
202 stars 28 forks source link

support define-syntax-parser builtin #53

Closed dannypsnl closed 1 year ago

Eugleo commented 2 years ago

I'm not sure whether it makes sense, but in the past I generated the tmLanguage.json file from the .yaml file that's in syntaxes/src. We should discuss whether it makes sense to use the yaml file, because if it does, it would be better to make the changes there and then just generate the json file from it to keep them both in sync. What do you think?

dannypsnl commented 2 years ago

Yes, that also confuse me once I find out there has a YAML. I think if keep YAML, maybe should ignore JSON, and generate JSON on deployment. After some read, I think YAML looks easier for maintaining.

dannypsnl commented 2 years ago

And I also found some interesting:

圖片

there have duplicated define-syntax...

Eugleo commented 2 years ago

Good point. Would you mind removing these duplicated values, and setting up the GitHub action to generate the json file automatically?

dannypsnl commented 2 years ago

Sure, whats your command for yaml to json?

Eugleo commented 2 years ago

Probably some external tool; I did all of this such a long time ago that I unfortunately have no idea. We will need to find something suitable.

dannypsnl commented 2 years ago

Ok, maybe I also do some research about conversion tool.

shocoman commented 2 years ago

Actually, there about 1500 duplicates in that list image

dannypsnl commented 2 years ago

@Eugleo I finally find one, I think you might use https://github.com/pedro-w/vscode-tmlanguage

This plugin has a command Convert to tmLanguage JSON can be triggered via shift + command + p in vscode.

dannypsnl commented 2 years ago
  1. I want to rebuild YAML file from JSON since the current YAML file is actually invalid.
  2. Then merge these branch first for new keywords support(define-syntax-parser).
  3. And we have another PR for remove duplicates