search

Eulercoder / fabulous

Fabulous Bot for Slack!
GNU General Public License v3.0
18 stars 22 forks source link

Added google search service #19

Closed anshulnsit closed 6 years ago

anshulnsit commented 6 years ago

I have added google search service. Can be used by typing ~google query

vicky002 commented 6 years ago

Hey @anshulnsit , can we show two results in the response?

As people generally, read at least first three results. I think we should show two.

anshulnsit commented 6 years ago

@vicky002 yes you are correct. Will update the code. @vicky002 currently i use beautifulsoup to scrape the data but that is slow. Is there another way of doing fast search.

vicky002 commented 6 years ago

@anshulnsit you can use Google Search API : https://developers.google.com/custom-search/?csw=1

This has some limitations though - 100 calls/per day, but it's enough for an organization, as seen if needs to do lot more than just a normal search, he will have to open browser and search.

To get results right inside Slack, 100 calls/day is good enough.

vicky002 commented 6 years ago

@anshulnsit 👇 There are conflicts.

anshulnsit commented 6 years ago

@vicky002 you already merged the PR to add the service. No need to merge this PR

vicky002 commented 6 years ago

closing it then.