search

Eulercoder / fabulous

Fabulous Bot for Slack!
GNU General Public License v3.0
18 stars 22 forks source link

added wiki service to the fabulous bot #21

Closed LordSomen closed 6 years ago

LordSomen commented 7 years ago

It is working , Current now it only shows the url but I can easily add more features to it. Yeah I parsed the MediaWiki api. Hope It will Works. thank you, Let me know if any changes or if any error occurs.

vicky002 commented 7 years ago

That's a lot of changes and commits. I will have to see your code in-depth before I merge to master.

Give me some time.

@bikrambhattacharya @nitish1995 you guys can review this code.

LordSomen commented 7 years ago

I just added some extra code for future development , If you want I can shrink the lines of code so that you can easily see the code in depth.Let me know .... And for the commits , It just got big because I just deleted some extra files that's all and as you can I didn't change anything in the source code , it's all about my code.

bikrambhattacharya commented 7 years ago

@vicky002 Service not working properly due to some import error. image

LordSomen commented 7 years ago

image I have no idea bro how this error was created , You can look at the image file , maybe you accidentally removed the import command , because in my computer no error is showing . Yes another thing I have no idea why for facebook my code can't find anything I think mediawiki api blocking it , ask Mark Zuckerberg !! LOL !! because after you mentioned this problem I tried with many others names but for them it is giving the corrrect url. image

but for facebook I think I have to add a exception . the best you can see about my code is even though user is not giving accurate input my wiki service is giving the the related result if they can found.
hope this will help!! Thank you!!

vicky002 commented 7 years ago

This is related to your code only. Check your code have you created Wikipedia module? There should be __init__.py file or see if you have given the path of your module properly.

LordSomen commented 7 years ago

Okk, but I need time , now I am busy it is not possible for 0.1.1 release!!! , If you want everything perfect!! I will try hard. Thank You.

vicky002 commented 6 years ago

no response yet, so closing this one.