Closed roychowdhuryrohit-dev closed 6 years ago
@roychowdhuryrohit-dev change in Makefile
and .gitignore
was not needed. That depends on the operating system and your configurations. I wrote them with the reference to Ubuntu OS.
Please squash all your commits into one. Read how to squash commits
Let me know once you're done
~ Vikesh
@vicky002 Since I was developing on the Ubuntu Docker image, I had to make some changes to Makefile only for my development purpose. But I had made sure to include my changes to gitignore file. But for some reasons, your gitignore file didn't really work. The changes was already commited. When I discovered them in my PR, I commited again to change them ( Makefile & gitignore ) back to their original. You can merge them effortlessly.
@roychowdhuryrohit-dev maybe you have to write in the README.md about how this new service works.
I can see you have mentioned many options in the news so we will have to write them in the documentation.
Nice work. Thanks for contributing to Fabulous Bot. :heart: :+1:
~ Vikesh
News feature has been added.