Eulercoder / fabulous

Fabulous Bot for Slack!
GNU General Public License v3.0
18 stars 22 forks source link

Q: Uses of both urllib and requests in service implementation. #56

Closed Buffer0x7cd closed 6 years ago

Buffer0x7cd commented 6 years ago

While looking through the implementation of different services, I noticed that some services used urllib for interacting with the external API while others used requests for the same. I was wondering if these uses are due to some different uses cases or just a matter of personal choice. If these changes are due to some edge cases then please let me know, because I was hoping to work on the services that use urllib and replace them with requests for consistency purpose.

vicky002 commented 6 years ago

I don't think there are any edge cases, people contributed and used whatever they found working.

Consider changing them all to requests.

Buffer0x7cd commented 6 years ago

Fixed