Remove repetitions to make the code more idiomatic

Euphrasiologist / nu_plugin_bio

Bioinformatics plugin for nushell.

24 stars 2 forks source link

Remove repetitions to make the code more idiomatic #10

Closed lavafroth closed 1 year ago

lavafroth commented 1 year ago

Changes

Implemented custom trait on the span type, creating a function to build an associated string value.
Create iterators for records to collect them into immutable record vectors.

Note: Some of the code got reformatted when cargo fmt was run.

Euphrasiologist commented 1 year ago

These changes look great, thanks for taking the time to have a look.

Haven't had much of a time to look yet, but will merge and test later.

Will you let me know when you've finished commiting?

lavafroth commented 1 year ago

As far as this PR goes, I'm pretty happy and don't plan to make further commits apart from any changes you suggest. Please feel free to go through the changes at your leisure.