search

EuracBiomedicalResearch / FamAgg

This is the development version of the FamAgg Bioconductor package.
https://EuracBiomedicalResearch.github.io/FamAgg
MIT License
0 stars 2 forks source link

Logical trait assignment fails #20

Closed the-x-at closed 4 years ago

the-x-at commented 4 years ago

Using a logical named vector for affection status in either the constructor of FAData or the setter function trait<- results in the following error message: trait has to be a named vector with the names corresponding to the IDs used in the pedigree. This is due to a missing reassignment of names that are dropped upon conversion of the logical vector to numeric in the setter method.

jorainer commented 4 years ago

Do you have a fix for this? Please wait some minutes until I have synced the current master with bioconductor.

jorainer commented 4 years ago

Ah, I did that already today morning.

the-x-at commented 4 years ago

The fix is straightforward, one has to reassign the names in the vector. If the FAData constructor calls the trait<- setter method, this is a one-liner.

jorainer commented 4 years ago

Merged and pushed also to Bioconductor.

the-x-at commented 4 years ago

So long and thanks for all the fish.