search

EurekaCommunity / ColorPickerRow

A color picker row for use with the Eureka form library
MIT License
56 stars 15 forks source link

Why does it print "xxx" when I select ColorRow? Should it even be selectable? #1

Closed Sweeper777 closed 7 years ago

Sweeper777 commented 7 years ago

I found these lines at ColorRow.swift line 49:

open override func didSelect() {
    print("xxx")

}

Why print xxx? Was this for debugging and you forgot to remove it? Also, ColorRow is supposed to be a row that displays a color only, just like a LabelRow displays text, right? Why is it even selectable in the first place?

alldritt commented 7 years ago

You are correct. ColorRow is display only, just like LabelRow, and should not be selectable and should not have a didSelect block. Thanks for the heads up and I apologize for the confusion.

alldritt commented 7 years ago

the didSelect() code has been removed.