search

EurekaCommunity / SplitRow

A row for Eureka to put two rows side by side into the same UITableViewCell
MIT License
56 stars 27 forks source link

Updates for SplitRow to work with Swift 5 & Eureka 5.0.0 #35

Closed kamerc closed 5 years ago

kamerc commented 5 years ago

Changes for Carthage

kamerc commented 5 years ago

@marbetschar can you verify this looks correct? I don't use Carthage personally so I wanted you to take a look before I push and create a release.

marbetschar commented 5 years ago

@kamerc will test as soon as I‘m back home. Will take some hours though.

marbetschar commented 5 years ago

Awesome job! One tiny thing: According to their CHANGELOG Eureka v5 requires iOS 9.3 and Xcode 10.0 - not iOS 10.0 We should also adhere to this, therefore the deployment target for SplitRow should be the same as for Eureka (= 9.3).

Feel free to merge and release SplitRow 2.0.0 as soon as you changed the deployment target version! 🎉🥳🎉

marbetschar commented 5 years ago

🎉🎉🎉 Thank you so much!!! 🙏🏼🙏🏼

kamerc commented 5 years ago

@marbetschar FYI that I created the 2.0.0 version on GitHub and am currently working on trying to push the podspec update to cocopods but dealing with errors related to simulators: - ERROR | [iOS] unknown: Encountered an unknown error (Could not find a ios simulator (valid values: com.apple.coresimulator.simruntime.ios-12-2, com.apple.coresimulator.simruntime.tvos-12-2, com.apple.coresimulator.simruntime.watchos-5-2). Ensure that Xcode -> Window -> Devices has at least one ios simulator listed or otherwise add one.) during validation.

I am about to step away from my desk so I will look back at it in a few hours.

kamerc commented 5 years ago

@marbetschar I finally figured out the issue and tried to push the PodSpec but got this error: [!] You (kate.mercer@sas.com) are not allowed to push new versions for this pod. The owners of this pod are marco@mandelkind.swiss and email@marco.betschart.name.

are you able to add me?

marbetschar commented 5 years ago

@kamerc good catch! Sure, hold on a sec

marbetschar commented 5 years ago

Done:

$ pod trunk add-owner SplitRow kate.mercer [at] sas.com
  - Owners:
    - Marco Betschart <marco [at] mandelkind.swiss>
    - Marco Betschart <email [at] marco.betschart.name>
    - Kate Mercer <kate.mercer [at] sas.com>
kamerc commented 5 years ago

thanks, version 2.0.0 has been pushed. I am now using it in my codebase.