search

EurekaCommunity / SplitRow

A row for Eureka to put two rows side by side into the same UITableViewCell
MIT License
56 stars 27 forks source link

Create Package.swift #44

Closed jimisaacs closed 4 years ago

jimisaacs commented 4 years ago

This is currently not ready to merge, as it depends on a fork of Eureka. When/if xmartlabs/Eureka#1976 gets merged. I'll update this.

jimisaacs commented 4 years ago

Well xmartlabs/Eureka#1976 was merged, thanks @mats-claassen

I've updated back to mainline repo, but still not ready for merge, as I think it needs a proper version of Eureka. Currently have it locked to a git revision.

AndrewBennet commented 4 years ago

@jimisaacs did you manage to get this working?

I ask because I am trying to get EurekaCommunity/ImageRow working with Swift Package Manager too, and I hit an issue where the build of the Eureka dependency fails with error no such module 'UIKit':

/Users/andrew/code/ImageRow/.build/checkouts/Eureka/Source/Core/BaseRow.swift:26:8: error: no such module 'UIKit'
import UIKit
       ^

I see some commits in this pull request where you've added import UIKit to various files -- looks like you may have hit a similar problem. Am I right?

A Swift Package Manager-supporting version of Eureka has now been released (5.2.0) so it would be good to get these additional libraries supported too (if possible).

jimisaacs commented 4 years ago

@AndrewBennet it's not a "problem" per se, it's just that how the library builds is updated where it doesn't auto import iOS specific libraries. You have to import them, including Foundation.

jimisaacs commented 4 years ago

@AndrewBennet I'm guessing your particular problem is related to target platform(s). Make sure you build for iOS, such as platforms: [.iOS(.v9)] for example. Without it, it will build for MacOS, where there is no UIKit.

jimisaacs commented 4 years ago

Looks like @funkenstrahlen figured it out ;) https://github.com/EurekaCommunity/ImageRow/pull/81

AndrewBennet commented 4 years ago

Ah great! I didn't notice that pull request - thanks for pointing me in that direction :)

jimisaacs commented 4 years ago

This should be ready now, please review.

patburns commented 4 years ago

Plus one on the review. We'd like to move this to SPM as well .

marbetschar commented 4 years ago

thank you guys for the SPM addition! just merged it into master.

@kamerc any chance you can create a new 2.2 release? Unfortunately I don't have access to any macOS momentarily.