search

EurekaCommunity / SplitRow

A row for Eureka to put two rows side by side into the same UITableViewCell
MIT License
56 stars 27 forks source link

Update SplitRow to accommodate validation #48

Closed wimzee-rcheng closed 3 years ago

wimzee-rcheng commented 3 years ago

See https://github.com/xmartlabs/Eureka/issues/2038 and https://github.com/EurekaCommunity/SplitRow/issues/37

marbetschar commented 3 years ago

thank you for working on this @wimzee-rcheng - this is awesome!!

Unfortunately I do no longer have access to a Mac - so I can't test this. Maybe someone (@SebastianThiebaud, @kamerc, ...) can give this a short test and confirm everything is working as intended? Then I'm happy to merge this in!

Thanks again for your contribution!

marbetschar commented 3 years ago

Since there was no feedback but the code looks good to me, I'm gonna merge this in.

kamerc commented 3 years ago

@marbetschar somehow I missed your tag back in January. @wimzee-rcheng thank you for doing this. I just downloaded the latest code and got a compile error. However, I noticed if I update the Eureka pod dependency to be the very latest, it built successfully. So I updated SplitRow's dependency to be on that latest Eureka version. I also pushed an updated to use version 2.2.0 in Carthage and Cocoapods pod spec.