Closed anivorlis closed 1 week ago
vercel[bot]
commented
1 week ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ep2024 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 24, 2024 5:46pm |
cybit
commented
1 week ago This seems to be based on an old version of main. (sessions.mdx, tickets.mdx) Could you please do a rebase of your PR?
anivorlis
commented
1 week ago Correct, @cybit please review now :)
cybit
commented
1 week ago Not sure how to add suggestions to these lines: Line 19:
* You are welcome to volunteer as much or as little as you want to, you just need to hold a ticket. We appreciate any help you can give us.Line 23: remove
anivorlis
commented
1 week ago Thank you for the comment @cybit, I updated the language after your comment (hopefully I understood correctly). If that is not the case let me know
cybit
commented
1 week ago My issue is with lines 19 and 23, @anivorlis . https://github.com/EuroPython/website/blob/8b4856936a65917aa62c82e14b30d444d956df0d/src/content/pages/volunteers.mdx?plain=1#L19 https://github.com/EuroPython/website/blob/8b4856936a65917aa62c82e14b30d444d956df0d/src/content/pages/volunteers.mdx?plain=1#L23
You need a ticket (19) And getting one is no longer possible so why have it as a perk ?(23)
anivorlis
commented
1 week ago Oh sorry, I thought you meant to rephrase the second paragraph. My bad, i will revert it.
Line 19: it is still possible Line 23: I think it is a perk that we gave to some volunteers - as many as we could. imo is better to keep it for transparency but I am fine with removing it
wdyt @cybit ?
cybit
commented
1 week ago Line 19: is is possible but you need a ticket. That's why up suggested.
* You are welcome to volunteer as much or as little as you want to, you just need to hold a ticket. We appreciate any help you can give us.If you prefer the "even if you hold a ticket" phrase. Not the important stuff.
Line23: I would remove it. Old people will get their voucher , new people will not fall over it. And with line 99 there should be an indication that yes, we did offer tickets, but they are out.
anivorlis
commented
1 week ago Agree on your suggestion for line 19: changed already hold with need to hold Line 23: maybe use strikethrough to indicate it was an option but no longer available? Alternatively we can used [CLOSED] inline with finaid
I like the website to reflect that this was a perk, which we gave to as many people as we could.
The form is closed, we are no longer accepting applicants through the form. We have made the selection and are awaiting for responses. If people want to volunteer some of their time, it would be greatly appreciated but as of now we cannot offer them a free ticket.