search

European-XFEL / EXtra-data

Access saved EuXFEL data
https://extra-data.rtfd.io
BSD 3-Clause "New" or "Revised" License
7 stars 14 forks source link

Selecting train IDs in DataCollection and SourceData #559

Closed tmichela closed 1 month ago

tmichela commented 1 month ago

Allow using the object[] syntax to select train IDs in addition to source or keys for DataCollection and SourceData

fadybishara commented 1 month ago

I have a minor comment (see review), otherwise everything LGTM! The RTD should also be updated, right?

tmichela commented 1 month ago

I added a few lines in the docs, will merge in a few days (when Thomas is back) if no-one objects the hybrid behavior.

takluyver commented 1 month ago

Thanks, the changes LGTM too (and I lean towards agreeing with Philipp - it seems worth blocking a run[source, index] selection to make clearer errors on simple mistakes)

tmichela commented 1 month ago

Thanks all for the review!