LPD has channel 5 shown twice and no channel 4 in `inspect()` and documentation

European-XFEL / EXtra-geom

Use EuXFEL detector geometry to assemble images

https://extra-geom.rtfd.io

BSD 3-Clause "New" or "Revised" License

5 stars 4 forks source link

LPD has channel 5 shown twice and no channel 4 in `inspect()` and documentation #224

Closed daniloefl closed 1 year ago

daniloefl commented 1 year ago

takluyver commented 1 year ago

Thanks! The diagram you showed is manually created, and I just made a mistake. I'll fix that.

The inspect output in the example docs also appears to be missing module 5 - this is because when that old geometry file was measured, LPD really was missing module 5. However, we've now got a method .from_quad_positions() which doesn't require a geometry file, so we should probably use that in the example.