search

European-XFEL / EXtra-geom

Use EuXFEL detector geometry to assemble images
https://extra-geom.rtfd.io
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

Label AGIPD-500k with M0-M7 module numbers #226

Closed takluyver closed 1 year ago

takluyver commented 1 year ago

@tmichela @philsmt @daniloefl - does this look right? Do you think anyone will be upset to lose the QxMy numbering?

image

Closes #223.

philsmt commented 1 year ago

@tmichela Could you possibly ask about the labeling on the HED side? It was back then done on behalf of DET, so mileage may vary.

tmichela commented 1 year ago

Is the QxMy labeling actually used beyond the calibration services?

takluyver commented 1 year ago

For other detectors, the QxMy pattern is certainly used - e.g. see these docs for AGIPD at MID: https://rtd.xfel.eu/docs/agipd-manual-mid/en/latest/introduction.html#naming-convention

Whether it's specifically used for AGIPD 500k is the question at hand. :slightly_smiling_face:

tmichela commented 1 year ago

Probably not, but who knows 🤷 To be safe, I'd maybe include both notation (QxMy (CHz)) but also that's probably not too important, so that's up to you.

takluyver commented 1 year ago

If we don't know of anyone using the QxMy notation for AGIPD 500k, and it does look like the Mx notation is used (I looked in Karabo), let's try this and see if anyone complains.