search

European-XFEL / EXtra-geom

Use EuXFEL detector geometry to assemble images
https://extra-geom.rtfd.io
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

Motor tracking for Jungfrau4M #303

Closed egorsobolev closed 2 months ago

egorsobolev commented 2 months ago

%subj%

@takluyver @JamesWrigley

takluyver commented 2 months ago

Like with European-XFEL/EXtra#224, I assume you've tried this out and checked that the results make sense? I don't know the details of JF4M, so I'm happy to trust you on the details of how motors & modules are assigned. The code LGTM, not that there's really any new code here. :slightly_smiling_face:

egorsobolev commented 2 months ago

Thanks, @takluyver for review. I asked all around and did the best what I can. But we will need to check the axis direction and assignment of the motors to the half next time when we will again refine the geometry. I will cross fingers and merge as is for now.

egorsobolev commented 2 months ago

Thanks, @JamesWrigley

JamesWrigley commented 2 months ago

Sorry, I actually meant that the class should be in the RST docs :sweat_smile: But it's not urgent, it can wait till you've verified the constants if you like.

egorsobolev commented 2 months ago

Hmm... you are right. Looks like, there is no place for it. I think we need a new section