search

European-XFEL / karabo-bridge-py

Tools to allow data exchange with Karabo, in particular streaming of data
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Small refactoring #49

Closed tmichela closed 5 years ago

tmichela commented 5 years ago

This removed some deprecated implementation details, and small changes:

codecov-io commented 5 years ago

Codecov Report

Merging #49 into master will increase coverage by 0.26%. The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   73.19%   73.46%   +0.26%     
==========================================
  Files           6        6              
  Lines         485      471      -14     
==========================================
- Hits          355      346       -9     
+ Misses        130      125       -5
Impacted Files Coverage Δ
karabo_bridge/simulation.py 74.58% <40%> (+0.59%) :arrow_up:
karabo_bridge/client.py 91.04% <85.71%> (+1.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0f200b...543579a. Read the comment docs.

takluyver commented 5 years ago

LGTM

tmichela commented 5 years ago

Thanks for the review!