search

European-XFEL / karabo-bridge-py

Tools to allow data exchange with Karabo, in particular streaming of data
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Choose data shape: file-like vs pipeline-like #52

Closed tmichela closed 5 years ago

tmichela commented 5 years ago

Simulation: Adds the option to generate data in a shape like in files or like the one provided by the calibration pipeline.

closes #48

tmichela commented 5 years ago

I opened a PR a few days ago: https://in.xfel.eu/gitlab/dataAnalysis/user-documentation/merge_requests/50

takluyver commented 5 years ago

Other than that, LGTM. Do you want to add a command-line argument as well?

codecov-io commented 5 years ago

Codecov Report

Merging #52 into master will increase coverage by 0.01%. The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   73.46%   73.47%   +0.01%     
==========================================
  Files           6        6              
  Lines         471      475       +4     
==========================================
+ Hits          346      349       +3     
- Misses        125      126       +1
Impacted Files Coverage Δ
karabo_bridge/cli/simulation.py 0% <0%> (ø) :arrow_up:
karabo_bridge/simulation.py 74.89% <83.33%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca20d72...d496b02. Read the comment docs.

tmichela commented 5 years ago

Thanks, I added the argument in command line as well

takluyver commented 5 years ago

LGTM