os.uname vs platform.uname

European-XFEL / karabo-bridge-py

Tools to allow data exchange with Karabo, in particular streaming of data

BSD 3-Clause "New" or "Revised" License

9 stars 4 forks source link

os.uname vs platform.uname #53

Closed CPrescher closed 5 years ago

CPrescher commented 5 years ago

Hi,

in the simulation.py file you are using os.uname, however this is not supported in windows cpython. I ran into issues with that since I am currently building conda packages for windows, because karabo_bridge is actually also now a dependency of karabo_data.

I know you do not officially support windows. But is it possible the rather use platform.uname than os.uname? The first one is also available on windows.

Best wishes, Clemens

takluyver commented 5 years ago

Seems reasonable. Or would something like socket.gethostname() be better? We're only using uname to get the hostname; I don't know if there are differences in how uname() and gethostname() do that.

I think we should mostly aim for our Python modules to work on Windows so long as that doesn't involve much extra effort, whether we want to call it 'supported' or not.