search

European-XFEL / karabo-bridge-py

Tools to allow data exchange with Karabo, in particular streaming of data
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Add pull socket support #57

Closed tmichela closed 4 years ago

tmichela commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #57 into master will increase coverage by 3.72%. The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   75.46%   79.18%   +3.72%     
==========================================
  Files           7        7              
  Lines         489      490       +1     
==========================================
+ Hits          369      388      +19     
+ Misses        120      102      -18
Impacted Files Coverage Δ
karabo_bridge/cli/simulation.py 0.00% <0.00%> (ø)
karabo_bridge/simulation.py 81.81% <69.04%> (+7.92%) :arrow_up:
karabo_bridge/cli/glimpse.py 69.67% <100.00%> (+0.50%) :arrow_up:
karabo_bridge/cli/monitor.py 79.16% <100.00%> (+1.89%) :arrow_up:
karabo_bridge/client.py 93.02% <100.00%> (+4.92%) :arrow_up:
karabo_bridge/serializer.py 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23ea6f9...ff71af4. Read the comment docs.

tmichela commented 4 years ago

I did not implement the timing between trains in the end as the data generation is much slower anyway... In addition I refactor the functions and removed duplication. now start_gen uses serveInThread to generate and send data.

takluyver commented 4 years ago

LGTM :-)

tmichela commented 4 years ago

\o/ thanks for the review!