European-XFEL / karabo_data

Python tools to read and analyse data from European XFEL
https://karabo-data.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
13 stars 7 forks source link

Fixes & example for DSSC distortion array #176

Closed takluyver closed 5 years ago

takluyver commented 5 years ago

I played around with @RobertRosca's notebook for #164, and spotted that we were getting the hexagons rather wrong. I've added a bit based on this to the example in the docs, and fixed the problems.

Here are the hexagons with the distortion array before the changes:

distortion-arr-before

And here they are after the changes:

distortion-arr-after

tmichela commented 5 years ago

No further comments from my side, looks good to me

takluyver commented 5 years ago

Thanks!

takluyver commented 5 years ago

(Removed the TODO comment because Monica from DET confirmed by email that the layout looks right)