Tiny cleanup - Githubissues

European-XFEL / karabo_data

Python tools to read and analyse data from European XFEL

https://karabo-data.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

13 stars 7 forks source link

Tiny cleanup #179

Closed tmichela closed 5 years ago

tmichela commented 5 years ago

Small PR trying to polish some things before the next release, mainly to rename DSSC classes to DSSC1M to stick to the naming convention.

I also:

removed old tests
updated setup.py
few pep8 auto-corrections and unused imports

takluyver commented 5 years ago

Thanks, this looks good. The DSSC geometry example notebook will need the name change as well.

takluyver commented 5 years ago

The test failures are because I accidentally removed os (overlapping pull requests - one removed it, one added code using it). If you merge from master, it should be OK.

takluyver commented 5 years ago

Ah, seemingly you don't need to merge from master.

tmichela commented 5 years ago

yep

takluyver commented 5 years ago

Other than that one import, LGTM

tmichela commented 5 years ago

Thanks