Deduplicate get_pixel_positions and to_distortion_array

European-XFEL / karabo_data

Python tools to read and analyse data from European XFEL

https://karabo-data.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

13 stars 7 forks source link

Closed takluyver closed 5 years ago

takluyver commented 5 years ago

These two methods are doing quite similar calculations. We should share some of the code between them, so there are fewer places for bugs to hide.

The differences are:

get_pixel_positions returns one 3D coordinate for each pixel, but to_distortion_array has one for each corner.
to_distortion_array shifts the origin so that no x/y coordinates are negative
to_distortion_array combines the module and slow-scan dimensions, to match data passed as a 2D array.

takluyver commented 5 years ago