European-XFEL / karabo_data

Python tools to read and analyse data from European XFEL
https://karabo-data.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
13 stars 7 forks source link

Allow creating and reusing an output array for assembling detector images #186

Closed takluyver closed 5 years ago

takluyver commented 5 years ago

As described in #165, this offers something like a 40% speedup if you're repeatedly assembling a train of images from the same detector with the same geometry. I've tested it with a train of 176 AGIPD images, and I think I'm seeing that kind of improvement, although the actual timings are rather variable.

@ebadkamil @zhujun98 - I think this is something karaboFAI could make use of. Whether or not you intend to, it would be good if you could review this code, as you're familiar with using it for this kind of scenario.

tmichela commented 5 years ago

LGTM