European-XFEL / karabo_data

Python tools to read and analyse data from European XFEL
https://karabo-data.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
13 stars 7 forks source link

Assume .h5 files are HDF5 when opening a run #187

Closed takluyver closed 5 years ago

takluyver commented 5 years ago

We already catch errors when opening the files, so we'll catch if we try to open a file that's not valid HDF5.

This speeds up opening a run by about 5% in my tests. That's a small gain, but it's low-hanging fruit - neither us nor the users need to do anything clever to use it. I'm thinking about how to get bigger speed improvements.

tmichela commented 5 years ago

LGTM