Add dtype for output array creation

European-XFEL / karabo_data

Python tools to read and analyse data from European XFEL

https://karabo-data.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

13 stars 7 forks source link

Add dtype for output array creation #197

Closed ebadkamil closed 5 years ago

ebadkamil commented 5 years ago

Want to use output_array_for_position_fast with specific dtype which may or maynot be np.float32 and may also change on the fly during online analysis in karaboFAI. It will be good to have dtype for this function rather than using _snapped().make_output_array for external tools. Or may be there is another better way.

@takluyver

takluyver commented 5 years ago

Thanks; that was an oversight. I guess you want a quick release so you can use this?

ebadkamil commented 5 years ago

I think there is no need to hurry. Probably we will not bring this funtionality in karaboFAI 0.5.1. We can wait till next week Monday. Jun says he may also have few more requirements for karabo_data.

@zhujun98

takluyver commented 5 years ago

OK. Let me know if you do want a release sooner; I haven't made any other changes yet, so it would be easy to do 0.6.1 with just this fix.