European-XFEL / karabo_data

Python tools to read and analyse data from European XFEL
https://karabo-data.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
13 stars 7 forks source link

More control of image parameters in geometry.plot_data_fast() #205

Closed antarcticrainforest closed 5 years ago

antarcticrainforest commented 5 years ago

This PR aims at resolving issue #204. The user can pass additional keyword arguments for an axis object (e.g subplots), controlling colorbar axis + properties and of course for controlling the image plotting itself. The agipd_geometry.ipynb notebook should demo this, hopefully - I don't have access to data.

tmichela commented 5 years ago

@antarcticrainforest is back in the game \o/

I won't help much reviewing plotting stuffs, I'll look at the notebook at least :)

takluyver commented 5 years ago

I've refined the examples in the notebook a bit, and I'm happy with this now. @tmichela, do you still want to have a look at it as well?

tmichela commented 5 years ago

LGTM

takluyver commented 5 years ago

Thanks @antarcticrainforest !