Only inspect one file for detector_info

European-XFEL / karabo_data

Python tools to read and analyse data from European XFEL

https://karabo-data.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

13 stars 7 forks source link

Only inspect one file for detector_info #219

Closed takluyver closed 5 years ago

takluyver commented 5 years ago

This approximates the total number of frames in the run - but that wasn't the most useful statistic anyway, because it can vary among detector modules, and we were picking an arbitrary module.

In combination with #206, this should mean we only open one HDF5 file for lsxfel (once the run map is cached), rather than all files for that detector module. Long runs can have 20 sequence files, so this should be much faster.

takluyver commented 5 years ago

At some point we'll need to be smarter if reduced data has varying numbers of frames saved for different trains, but I'm not trying to tackle that here.

tmichela commented 5 years ago

Minor comment, LGTM