EuropeanUniversityFoundation / occapi-openapi

OpenAPI definitions for the Open Course Catalogue API
MIT License
0 stars 1 forks source link

iscedCode in Programme/Course resources #26

Open athanani opened 2 years ago

athanani commented 2 years ago

Hello,

I have a few questions about the iscedCode attribute.

I was trying to connect the iscedCode of a Programme with the parent OUnit as you suggested. A study program based on my experience could cover more than one fields of education, for example the undergraduate study program of the Computer Science department of AUTh that I am in, covers mainly the "06 Information and Communication Technologies (ICTs)" field but there is also a lot of focus given to the "054 Mathematics and statistics" field.

Would it make sense if the iscedCode attribute in the Programme endpoints was an array of objects instead of a simple string, so that the main iscedCode field and the secondary fields could be mentioned or it is meant just for the main field that is covered?

Also, the ISCED-F code redirect link in the iscedCode attribute description of Programme and Course endpoints in the documentation, doesn't seem to work properly.

tiagosimoes-euf commented 2 years ago

You raise a very good point. Multiple values for fields of education would certainly cover some cases that we've seen on the initial implementations. I will introduce a change proposal and reach out to other colleagues before making any breaking changes. Not entirely sure about primary / secondary fields, that's worth discussing as well.

As per the link, I will try to find a good one and replace the broken one. Thank you!

tiagosimoes-euf commented 2 years ago

Link is replaced in this commit

tiagosimoes-euf commented 2 years ago

Opened a pull request with all fields of study now allowing multiple values

27