search

Eurotermbank / Federated-Network-Toolkit-deployment

Other
2 stars 1 forks source link

administrativeStatus values not matching the TBX picklist #22

Closed mariask2 closed 3 years ago

mariask2 commented 3 years ago

According to the following documentation: https://www.gala-global.org/sites/default/files/migrated- pages/docs/tbx_oscar_0.pdf

The values of the TBX picklist should be: The element when its type attribute has the value 'administrativeStatus' shall contain one of the following values: • admittedTerm-admn-sts • deprecatedTerm-admn-sts • legalTerm-admn-sts • preferredTerm-admn-sts • regulatedTerm-admn-sts • standardizedTerm-admn-sts • supersededTerm-admn-sts

However, the exported TBX gives the values "Preferred term", "Admitted term" and "Deprecated term":

<termEntry id="tgl-1468">
<langSet xml:lang="en">
    <ntig id="6213">
      <termGrp>
        <term>a preferred-term that should be given a prominence-marker (e.g. be displayed in a bold font)</term>
      </termGrp>
      <termNote type="administrativeStatus">Preferred term</termNote>
      <admin type="status">approved</admin>
    </ntig>
    <ntig id="6214">
      <termGrp>
        <term>an admitted-term that should be given a non-prominence-marker (e.g. be displayed in non-bold font )</term>
      </termGrp>
      <termNote type="administrativeStatus">Admitted term</termNote>
      <admin type="status">approved</admin>
    </ntig>
  </langSet>
</termEntry>
<termEntry id="tgl-1469">
  <langSet xml:lang="en">
    <ntig id="6215">
      <termGrp>
        <term>preferred-term that should be given a prominence-marker (e.g. be displayed in a bold font)</term>
      </termGrp>
      <termNote type="administrativeStatus">Preferred term</termNote>
      <admin type="status">approved</admin>
    </ntig>
    <ntig id="6216">
      <termGrp>
        <term>deprecated-term that should be given a deprecated-marker (e.g. be displayed with strike-through)</term>
      </termGrp>
      <termNote type="administrativeStatus">Deprecated term</termNote>
      <admin type="status">approved</admin>
    </ntig>
  </langSet>
</termEntry>

The standard referred to might be an older one than the one you are using, but I guess you plan to also allow import of older TBX. Now the behaviour is strange for when first importing a TBX that uses values from the referenced pick list, and then choosing to edit the term. When you choose "View", you see that Administrative status is deprecated arabic-deprecatedTerm-admn-sts

However, when you choose to edit the term, the information given for Administrative status is no longer to be seen: administrative-status-empty

andish commented 3 years ago

For Administrative status field, allowed system values should change to (user friendly names can stay as they are now):

• admittedTerm-admn-sts • deprecatedTerm-admn-sts • legalTerm-admn-sts • preferredTerm-admn-sts • regulatedTerm-admn-sts • standardizedTerm-admn-sts • supersededTerm-admn-sts

Still there is a question what to do, if other values for restricted data categories were imported using bulk import.